Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: more precise display in correctness tests for seeded operators #618

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Nov 7, 2024

DIT source

  • In correctness tests for pushforward, pullback and hvp, test equality of each individual tangent instead of testing all(res .≈ scen.res). This allows the @test macro to display the values of both sides.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (d9fc042) to head (1a042c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #618   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files         110      110           
  Lines        5427     5439   +12     
=======================================
+ Hits         5306     5318   +12     
  Misses        121      121           
Flag Coverage Δ
DI 98.93% <ø> (ø)
DIT 95.59% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 3094dca into main Nov 7, 2024
47 checks passed
@gdalle gdalle deleted the gd/correctness_display branch November 7, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant