Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more tests compatible with 1.11 #552

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Make more tests compatible with 1.11 #552

merged 8 commits into from
Oct 8, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Oct 8, 2024

DI source

  • Ensure that hvp_mode never returns nothing

DIT source

  • Improve compatibility tests for scenarios to exclude those that will never work with AutoSparse, SecondOrder or a combination thereof

DI tests

  • Replace Enzyme with ReverseDiff in SparsityDetector tests
  • Put SecondOrder(AutoForwardDiff, X) tests inside X tests, for X in [AutoZygote, AutoReverseDiff] (no new deps)
  • Put SecondOrder(AutoEnzyme, AutoEnzyme) tests inside Enzyme tests
  • Shorten sparse backend construction with MyAutoSparse

@gdalle gdalle marked this pull request as ready for review October 8, 2024 10:33
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (a074f88) to head (ef416fd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
+ Coverage   98.29%   98.39%   +0.10%     
==========================================
  Files         108      107       -1     
  Lines        4742     4739       -3     
==========================================
+ Hits         4661     4663       +2     
+ Misses         81       76       -5     
Flag Coverage Δ
DI 98.63% <100.00%> (+0.15%) ⬆️
DIT 97.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit efb5acf into main Oct 8, 2024
43 checks passed
@gdalle gdalle deleted the gd/ready_11 branch October 8, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants