Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More type stability tests #543

Merged
merged 5 commits into from
Oct 5, 2024
Merged

More type stability tests #543

merged 5 commits into from
Oct 5, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Oct 4, 2024

DIT source

  • Add detailed options to type stability checking, by passing the following kwarg to test_differentiation
type_stability = (; preparation=false, prepared_op=true, unprepared_op=false)

DI and DIT tests

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 94.24460% with 8 lines in your changes missing coverage. Please review.

Project coverage is 98.43%. Comparing base (c47e26c) to head (a3d3bf2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...tionInterfaceTest/src/tests/type_stability_eval.jl 93.93% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
- Coverage   98.57%   98.43%   -0.14%     
==========================================
  Files         107      107              
  Lines        4620     4724     +104     
==========================================
+ Hits         4554     4650      +96     
- Misses         66       74       +8     
Flag Coverage Δ
DI 98.68% <100.00%> (+0.01%) ⬆️
DIT 97.90% <94.20%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle linked an issue Oct 4, 2024 that may be closed by this pull request
@gdalle gdalle marked this pull request as ready for review October 5, 2024 06:42
@gdalle gdalle merged commit 88c48c1 into main Oct 5, 2024
52 checks passed
@gdalle gdalle deleted the gd/more_typestab branch October 5, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow testing type stability of operators without preparation
2 participants