Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Transition from Tapir to Mooncake #500

Merged
merged 4 commits into from
Sep 25, 2024
Merged

[BREAKING] Transition from Tapir to Mooncake #500

merged 4 commits into from
Sep 25, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 25, 2024

Warning

Breaking change: AutoTapir is no longer supported, replaced by AutoMooncake (see SciML/ADTypes.jl#89)

DI deps

  • Replace Tapir with Mooncake, bump ADTypes compat

DI extensions, tests, CI

  • Rename everything from Tapir to Mooncake
  • Handle new Mooncake.Config (ping @willtebbutt)
  • Implement multi-argument support
  • Reactivate other tests

@gdalle gdalle marked this pull request as draft September 25, 2024 12:32
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 89.87342% with 8 lines in your changes missing coverage. Please review.

Project coverage is 98.43%. Comparing base (987ca87) to head (a95cd2e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../ext/DifferentiationInterfaceMooncakeExt/onearg.jl 75.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   98.45%   98.43%   -0.02%     
==========================================
  Files         106      106              
  Lines        4452     4471      +19     
==========================================
+ Hits         4383     4401      +18     
- Misses         69       70       +1     
Flag Coverage Δ
DI 98.48% <89.87%> (-0.03%) ⬇️
DIT 98.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Member Author

gdalle commented Sep 25, 2024

I think multi-argument support is operational, care to take a look? All you need to know is that:

  • contexts can contain any number of arguments (including 0), wrapped in specific types like Constant <: Context
  • one can access the actual data with unwrap, e.g. unwrap(Constant(c)) == c

@gdalle gdalle marked this pull request as ready for review September 25, 2024 13:30
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely looks good, just a couple of queries.

Co-authored-by: Will Tebbutt <wt0881@my.bristol.ac.uk>
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my perspective. I don't see how we could need to do anything else in this PR that is breaking, so if there is anything that's not been implemented optimally, we can revisit the details later on.

@gdalle gdalle merged commit 1307890 into main Sep 25, 2024
60 checks passed
@gdalle gdalle deleted the gd/mooncake branch September 25, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants