-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Transition from Tapir to Mooncake #500
Conversation
DifferentiationInterface/ext/DifferentiationInterfaceMooncakeExt/onearg.jl
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 98.45% 98.43% -0.02%
==========================================
Files 106 106
Lines 4452 4471 +19
==========================================
+ Hits 4383 4401 +18
- Misses 69 70 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think multi-argument support is operational, care to take a look? All you need to know is that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely looks good, just a couple of queries.
...tionInterface/ext/DifferentiationInterfaceMooncakeExt/DifferentiationInterfaceMooncakeExt.jl
Outdated
Show resolved
Hide resolved
DifferentiationInterface/ext/DifferentiationInterfaceMooncakeExt/onearg.jl
Show resolved
Hide resolved
DifferentiationInterface/ext/DifferentiationInterfaceMooncakeExt/onearg.jl
Show resolved
Hide resolved
Co-authored-by: Will Tebbutt <wt0881@my.bristol.ac.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my perspective. I don't see how we could need to do anything else in this PR that is breaking, so if there is anything that's not been implemented optimally, we can revisit the details later on.
Warning
Breaking change:
AutoTapir
is no longer supported, replaced byAutoMooncake
(see SciML/ADTypes.jl#89)DI deps
DI extensions, tests, CI
Mooncake.Config
(ping @willtebbutt)