Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better HVP in reverse over forward #494

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Better HVP in reverse over forward #494

merged 1 commit into from
Sep 24, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 24, 2024

DI source

  • Improve HVP for reverse-over-forward by putting the tangent in a Constant context

DI tests

  • Add FromPrimitive tests for heterogeneous SecondOrder backends

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (472c027) to head (125ea9a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
+ Coverage   98.30%   98.42%   +0.11%     
==========================================
  Files         106      106              
  Lines        4309     4309              
==========================================
+ Hits         4236     4241       +5     
+ Misses         73       68       -5     
Flag Coverage Δ
DI 98.48% <100.00%> (+0.17%) ⬆️
DIT 98.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 932913a into main Sep 24, 2024
60 checks passed
@gdalle gdalle deleted the gd/revfor_hvp branch September 25, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants