Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of functors for second order #460

Merged
merged 3 commits into from
Sep 8, 2024
Merged

Get rid of functors for second order #460

merged 3 commits into from
Sep 8, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 8, 2024

DI source

  • Remove private functors Gradient, PushforwardFixedSeed and InnerDerivative, which were used in second order operators

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.53%. Comparing base (2411653) to head (f2f84d9).

Files with missing lines Patch % Lines
DifferentiationInterface/src/second_order/hvp.jl 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   98.51%   98.53%   +0.01%     
==========================================
  Files         106      106              
  Lines        4250     4234      -16     
==========================================
- Hits         4187     4172      -15     
+ Misses         63       62       -1     
Flag Coverage Δ
DI 98.69% <81.81%> (+0.02%) ⬆️
DIT 98.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review September 8, 2024 09:15
@gdalle gdalle merged commit b3c9b0a into main Sep 8, 2024
102 of 105 checks passed
@gdalle gdalle deleted the gd/remove_functors branch September 8, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants