Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound FastDifferentiation compat to <0.4 #454

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Bound FastDifferentiation compat to <0.4 #454

merged 1 commit into from
Sep 7, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 7, 2024

DI compat

  • Restrict weakdep FastDifferentiation to v0.3.17 because v0.4.0 is broken

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (b2dcdef) to head (623335b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         107      107           
  Lines        4287     4287           
=======================================
  Hits         4224     4224           
  Misses         63       63           
Flag Coverage Δ
DI 98.68% <ø> (ø)
DIT 98.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review September 7, 2024 07:22
@gdalle gdalle merged commit 25289d9 into main Sep 7, 2024
103 of 105 checks passed
@gdalle gdalle deleted the gd/fastdiff branch September 7, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants