Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FiniteDiff derivative #436

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Fix FiniteDiff derivative #436

merged 1 commit into from
Sep 1, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 1, 2024

DI extensions

  • FiniteDiff: use cache for derivative of f!
  • ChainRules, Tracker and Zygote: fix preparation dispatch

@gdalle gdalle linked an issue Sep 1, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (7c60378) to head (de041a4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #436   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files         102      102           
  Lines        4885     4886    +1     
=======================================
+ Hits         4574     4575    +1     
  Misses        311      311           
Flag Coverage Δ
DI 99.27% <100.00%> (+<0.01%) ⬆️
DIT 86.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review September 1, 2024 17:10
@gdalle gdalle merged commit e89aab3 into main Sep 1, 2024
104 of 105 checks passed
@gdalle gdalle deleted the gd/fixes branch September 1, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two-argument derivative with FiniteDiff is not prepared?
2 participants