Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag construction in ForwardDiff #357

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Fix tag construction in ForwardDiff #357

merged 1 commit into from
Jul 15, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Jul 15, 2024

DI extensions

  • Tags were not properly constructed in ForwardDiff extension: we need to use the Tag(f, R) constructor to increment the global tag counter, whereas Tag{F, R} fails. Examples of correct tag construction: here, here.

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.89%. Comparing base (454f312) to head (c21a3a1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files         101      101           
  Lines        4830     4830           
=======================================
  Hits         4680     4680           
  Misses        150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 11c01c5 into main Jul 15, 2024
53 checks passed
@gdalle gdalle deleted the gd/tag branch July 15, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WaterLily using ForwardDiff and Enzyme through DifferentiationInterface
2 participants