Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default batch size to 1 #340

Merged
merged 6 commits into from
Jun 27, 2024
Merged

Set default batch size to 1 #340

merged 6 commits into from
Jun 27, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Jun 27, 2024

Versions

  • Bump DI to v0.5.7

DI source

  • Set default batch size to 1 for backends that don't overload it

DI extensions

DI tests

  • Group internal backend tests, add a test for pick_batchsize there

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.33%. Comparing base (ff529cb) to head (c82d488).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   96.77%   95.33%   -1.44%     
==========================================
  Files         101      100       -1     
  Lines        4831     4828       -3     
==========================================
- Hits         4675     4603      -72     
- Misses        156      225      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle added the core Related to the core utilities of the package label Jun 27, 2024
@gdalle gdalle merged commit 102fa86 into main Jun 27, 2024
36 checks passed
@gdalle gdalle deleted the gd/batchsize_1 branch June 27, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to the core utilities of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants