Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom printing #332

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Remove custom printing #332

merged 6 commits into from
Jun 26, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Jun 26, 2024

Following SciML/ADTypes.jl#64, there is no more need for the custom printing utilities in DI.

DI source

  • Remove backend_str, replace backend_package_name with package_name (with a much simpler implementation that extracts "Something" from "AutoSomething(...)".
  • Fix display of SecondOrder and DifferentiateWith

DI docs

  • Remove uses of backend_str

DIT source

  • Remove uses of backend_str

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.73%. Comparing base (bb0d874) to head (984cf5c).

Files Patch % Lines
DifferentiationInterface/src/utils/printing.jl 71.42% 2 Missing ⚠️
DifferentiationInterface/src/utils/exceptions.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         101      101           
  Lines        4865     4840   -25     
=======================================
- Hits         4706     4682   -24     
+ Misses        159      158    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit feb17b0 into main Jun 26, 2024
53 checks passed
@gdalle gdalle deleted the gd/no_special_print branch June 26, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants