Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batched ForwardDiff pushforward #328

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Batched ForwardDiff pushforward #328

merged 6 commits into from
Jun 25, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Jun 24, 2024

DI extensions

  • Implement batched pushforward in ForwardDiff by extracting all the partials from a Dual number, and converting an array-of-tuples into a tuple-of-arrays
  • Fix ForwardDiff chunk choice so that it never exceeds length(x)

DI source

  • Add batched operators to FromPrimitive so that they better reflect the underlying backend

DIT source

  • Remove function filter in type stability check

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (4390675) to head (f20dfc1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   94.93%   96.56%   +1.63%     
==========================================
  Files          95       96       +1     
  Lines        4557     4625      +68     
==========================================
+ Hits         4326     4466     +140     
+ Misses        231      159      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle added the backend Related to one or more autodiff backends label Jun 25, 2024
@gdalle gdalle marked this pull request as ready for review June 25, 2024 08:06
@gdalle gdalle merged commit 86f1e02 into main Jun 25, 2024
53 checks passed
@gdalle gdalle deleted the gd/batch_fd branch June 25, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to one or more autodiff backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants