Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate compressed evaluation and decompression for sparse #212

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Apr 25, 2024

Core

  • Split sparse handling into smaller files
  • Define CompressedMatrix type with functions decompress! and decompress_symmetric!
  • Define proper Extras subtypes for sparse Jacobian and sparse Hessian, with a cache for all seeds and resulting compressed columns
  • Decouple compressed evaluation of columns / rows from decompression
  • Document GreedyColoringAlgorithm in the main package (not part of the public API)
  • Define and document SymbolicsSparsityDetector in the main package (not part of the public API)

Tests

  • Add extras type test within correctness.jl
  • Add coloring number tests

Extensions

  • Fix extras subtyping for Enzyme and FiniteDiff

@gdalle gdalle marked this pull request as ready for review April 25, 2024 12:04
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 94.53%. Comparing base (5161e56) to head (0a484ac).
Report is 2 commits behind head on main.

Files Patch % Lines
...ferentiationInterfaceTest/src/tests/correctness.jl 50.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   96.39%   94.53%   -1.87%     
==========================================
  Files          65       15      -50     
  Lines        3554     1610    -1944     
==========================================
- Hits         3426     1522    -1904     
+ Misses        128       88      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle linked an issue Apr 25, 2024 that may be closed by this pull request
@gdalle gdalle merged commit d4a9d9e into main Apr 25, 2024
5 checks passed
@gdalle gdalle deleted the gd/better_sparse_extras branch April 25, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test that preparation returns extras of the right type
2 participants