Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests for sparse Jacobians and Hessians #189

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Apr 18, 2024

Tests

  • Fix discrepancy in sparse_scenarios() definition (no x)
  • Add sparse Scenarios for vec-to-vec, vec-to-mat, mat-to-vec, mat-to-mat, vec-to-num and mat-to-num functions
  • Make sure that the Hessian is not constant and actually depends on the input, by using a third power

Extensions

  • Work around Symbolics.sparsejacobian and Symbolics.sparsehessian accepting only vectors

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 2.27273% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 91.79%. Comparing base (dfd6022) to head (e2aee6e).

Files Patch % Lines
...fferentiationInterfaceTest/src/scenarios/sparse.jl 0.00% 86 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   93.94%   91.79%   -2.16%     
==========================================
  Files          67       67              
  Lines        3287     3364      +77     
==========================================
  Hits         3088     3088              
- Misses        199      276      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit afa82d7 into main Apr 18, 2024
5 checks passed
@gdalle gdalle deleted the gd/more_sparse_tests branch April 18, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants