Make Zygote extension depend on ForwardDiff too (#303)

JuliaDiff · Jun 5, 2024 · 7d99da1 · 7d99da1
1 parent 042d75f
commit 7d99da1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/DifferentiationInterface/Project.toml b/DifferentiationInterface/Project.toml
@@ -41,7 +41,7 @@ DifferentiationInterfaceReverseDiffExt = "ReverseDiff"
 DifferentiationInterfaceSymbolicsExt = "Symbolics"
 DifferentiationInterfaceTapirExt = "Tapir"
 DifferentiationInterfaceTrackerExt = "Tracker"
-DifferentiationInterfaceZygoteExt = "Zygote"
+DifferentiationInterfaceZygoteExt = ["Zygote", "ForwardDiff"]
 
 [compat]
 ADTypes = "1.2.0"

diff --git a/...ationInterface/ext/DifferentiationInterfaceZygoteExt/DifferentiationInterfaceZygoteExt.jl b/...ationInterface/ext/DifferentiationInterfaceZygoteExt/DifferentiationInterfaceZygoteExt.jl
@@ -10,6 +10,7 @@ using DifferentiationInterface:
     NoPullbackExtras,
     PullbackExtras
 using DocStringExtensions
+using ForwardDiff: ForwardDiff
 using Zygote:
     ZygoteRuleConfig, gradient, hessian, jacobian, pullback, withgradient, withjacobian
 using Compat
@@ -93,9 +94,9 @@ function DI.jacobian!(f, jac, backend::AutoZygote, x, extras::NoJacobianExtras)
     return copyto!(jac, DI.jacobian(f, backend, x, extras))
 end
 
-## HVP (with ForwardDiff)
+## HVP
 
-# TODO: find a way to do this without cheating?
+# Beware, this uses ForwardDiff for the inner differentiation
 
 struct ZygoteHVPExtras{G,PE} <: HVPExtras
     ∇f::G