Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Zero rather than DoesNotExist for NO_FIELDS #71

Merged
merged 1 commit into from
Jan 10, 2020
Merged

use Zero rather than DoesNotExist for NO_FIELDS #71

merged 1 commit into from
Jan 10, 2020

Conversation

oxinabox
Copy link
Member

Closes #52

@oxinabox
Copy link
Member Author

oxinabox commented Jan 5, 2020

bump

@oxinabox
Copy link
Member Author

@nickrobinson251 did I answer your questions in
#52 (comment)
?

If so can this be approved?

@willtebbutt
Copy link
Member

I'm happy with this. We can revert if later on we realise that it's problematic.

@oxinabox oxinabox merged commit b9abd85 into master Jan 10, 2020
@oxinabox oxinabox mentioned this pull request Jan 10, 2020
Merged
@YingboMa YingboMa deleted the ox/nofieldsiszero branch January 10, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willtebbutt willtebbutt willtebbutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What type should NO_FIELDS be?
2 participants
@oxinabox @willtebbutt