Cut down to bare minimum for AbstractChainRules #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the PR, maybe some of the rules could be kept here? The ones in |
|
As we add more and more rules for Base, those are going to grow. |
|
This PR matches to JuliaDiff/ChainRules.jl#67 |
willtebbutt
reviewed
Aug 2, 2019
willtebbutt
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now master just contains the whole of ChainRules.jl
This PR reduces it down to the minimum stuff.
It does still have Cassette which technically can move to being in ChainRules,
but Cassette is actually an very lightweight dependency.
And we plan to remove it at some point