Run CI on tags #118
Merged
Run CI on tags #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 8 8
Lines 428 428
=======================================
Hits 355 355
Misses 73 73 ☔ View full report in Codecov by Sentry. |
|
Why don't we have a separate Docs.yml action? There's no need to rerun CI tests on tags, we only need the docs. |
|
I guess it doesn't hurt to prove that the tests pass specifically for the tag you want. Otherwise if you wanna check you have to go back in time and look for the tests of the associated commit. But I don't feel strongly about either option |
|
I think it's sufficient to run CI once for every commit. If you go to a tag, you also end up with the commit with the CI runs next to it. |
|
Alright, I'll split out a docs workflow tomorrow |
devmotion
reviewed
Oct 13, 2023
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes the lack of a stable docs build