-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main interface implementation and first benchmark problems #4
Conversation
@gdalle JET doesn't like my code, do you know what's wrong? I don't understand its error message. |
I think the key line is this one:
You probably cannot force the sampling type of a Distribution |
You're right, I need to specify the type in the distribution constructor, not in the sampling. Thanks! |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
incroyable !!!! |
Just came back from holidays, starting a fresh PR! |
This PR is an attempt at a common interface for all Benchmarks:
AbstractBenchmark
abstract typeDataSample
struct for staoring samplegenerate_dataset
allows generating a dataset (of typeVector{<:DataSample}
) for training/testing of requested sizegenerate_maximizer
generates a callable optimizer functiongenerate_statistical_model
generates an untrained Flux model specific for the considered benchmarkplot_data
can visualize isnatnces/solutions, depending on the given inputscompute_gap
computes the performance metric of given pipeline on given datasetAnd some implemented examples;
WarcraftBenchmark
: path finding on image mapsPortfolioOptimizationBenchmark
: portfolio optimization with uncertain pricesFixedSizeShortestPathBenchmark
: shortest path on a square graph of fixed sizeSubsetSelectionBenchmark
: minimalist pipeline with top-k layerQuestions:
pipeline
struct?Note: we should rename the package as
DecisionFocusedLearningBenchmarks
, and also rename all names mentioning InferOpt