Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust tests for latest Julia master #584

Merged
merged 2 commits into from
Aug 25, 2023
Merged

adjust tests for latest Julia master #584

merged 2 commits into from
Aug 25, 2023

Conversation

aviatesk
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #584 (bc7950d) into master (910cb6f) will increase coverage by 0.11%.
The diff coverage is n/a.

❗ Current head bc7950d differs from pull request most recent head 8523cfc. Consider uploading reports for the commit 8523cfc to get more accurate results

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
+ Coverage   86.46%   86.57%   +0.11%     
==========================================
  Files          12       12              
  Lines        2534     2533       -1     
==========================================
+ Hits         2191     2193       +2     
+ Misses        343      340       -3     

see 5 files with indirect coverage changes

@aviatesk aviatesk force-pushed the avi/test branch 2 times, most recently from bc7950d to 8523cfc Compare August 25, 2023 08:28
@aviatesk
Copy link
Member Author

Tests are failing due to sketchy segfaults, but it looks like they are happening on master too. I would like to move forward this for now and try to fix the segfault in a separate PR.

@KristofferC
Copy link
Member

Sounds good

@aviatesk aviatesk merged commit c93dedf into master Aug 25, 2023
@aviatesk aviatesk deleted the avi/test branch August 25, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants