Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to check builtin consistency #541

Merged
merged 4 commits into from
Jul 25, 2022

Conversation

pfitzseb
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #541 (cbf40fe) into master (fd31ef3) will decrease coverage by 0.24%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
- Coverage   85.67%   85.43%   -0.25%     
==========================================
  Files          12       12              
  Lines        2415     2423       +8     
==========================================
+ Hits         2069     2070       +1     
- Misses        346      353       +7     
Impacted Files Coverage Δ
src/builtins.jl 64.08% <12.50%> (-1.75%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@KristofferC
Copy link
Member

Why should this not be a normal test?

@pfitzseb
Copy link
Member Author

Because generate_builtins.jl only runs on ~nightly, but that fails tests currently and we'd never notice the failure like that. So now I'm running this as a separate action and as part of runtests.jl.

@pfitzseb pfitzseb changed the title [WIP] Add action to check builtin consistency Add action to check builtin consistency Jul 25, 2022
@pfitzseb pfitzseb requested a review from KristofferC July 25, 2022 09:46
@pfitzseb pfitzseb merged commit 20e5204 into master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants