Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_doc_expr by constraining number of args #539

Merged
merged 1 commit into from
Jul 24, 2022

Conversation

mgkurtz
Copy link
Contributor

@mgkurtz mgkurtz commented Jul 17, 2022

Solution as discussed in issue #538.

Without this change the first added test fails and the collect from the second test throws the BoundsError from #538 by calling iterate(::ExprSplitter).

@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #539 (3e23ec6) into master (7fe78fa) will decrease coverage by 1.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
- Coverage   86.93%   85.71%   -1.22%     
==========================================
  Files          12       12              
  Lines        2525     2415     -110     
==========================================
- Hits         2195     2070     -125     
- Misses        330      345      +15     
Impacted Files Coverage Δ
src/utils.jl 87.55% <100.00%> (-0.73%) ⬇️
src/builtins.jl 66.24% <0.00%> (-5.53%) ⬇️
src/packagedef.jl 84.44% <0.00%> (-3.80%) ⬇️
src/types.jl 75.64% <0.00%> (-1.52%) ⬇️
src/interpret.jl 77.75% <0.00%> (-1.18%) ⬇️
src/optimize.jl 97.40% <0.00%> (-0.46%) ⬇️
src/commands.jl 93.15% <0.00%> (-0.30%) ⬇️
src/breakpoints.jl 95.55% <0.00%> (-0.24%) ⬇️
src/construct.jl 91.80% <0.00%> (-0.19%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe78fa...3e23ec6. Read the comment docs.

Copy link
Member

@pfitzseb pfitzseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@timholy timholy merged commit 75bc4fb into JuliaDebug:master Jul 24, 2022
@timholy
Copy link
Member

timholy commented Jul 24, 2022

Thanks @mgkurtz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants