Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove more legacy code #509

Merged
merged 1 commit into from
Dec 16, 2021
Merged

remove more legacy code #509

merged 1 commit into from
Dec 16, 2021

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Dec 16, 2021

We can eliminate this code since :struct_type/:abstract_type/:primitive_type
expressions no longer exist in v1.6 and higher.

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #509 (d07bf59) into master (d5cb560) will increase coverage by 1.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
+ Coverage   83.53%   84.67%   +1.14%     
==========================================
  Files          12       12              
  Lines        2447     2402      -45     
==========================================
- Hits         2044     2034      -10     
+ Misses        403      368      -35     
Impacted Files Coverage Δ
src/interpret.jl 81.06% <ø> (+4.99%) ⬆️
src/precompile.jl 0.00% <ø> (ø)
src/utils.jl 85.71% <ø> (+0.60%) ⬆️
src/optimize.jl 96.91% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5cb560...d07bf59. Read the comment docs.

We can eliminate this code since there are no `:struct_type`/`:abstract_type`/`:primitive_type`
expressions anymore in v1.6 and higher.
Copy link
Collaborator

@simeonschaub simeonschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aviatesk aviatesk merged commit f612188 into master Dec 16, 2021
@aviatesk aviatesk deleted the avi/rmmore branch December 16, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants