Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing arg to scalar event #130

Merged

Conversation

PhilReinhold
Copy link
Contributor

It appears that ScalarEvent requires an additional "style" argument which is not passed in the fallback method for __parse_node. I observed this failure when parsing a tag with an empty body, e.g.

thing:
    x: !MyTag

@kescobo
Copy link
Collaborator

kescobo commented Apr 4, 2023

Would you please add a test that covers your case that failed?

@kescobo kescobo added the bug label Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.13 🎉

Comparison is base (6d1b676) 86.46% compared to head (3bbd608) 86.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   86.46%   86.59%   +0.13%     
==========================================
  Files          12       12              
  Lines        1625     1626       +1     
==========================================
+ Hits         1405     1408       +3     
+ Misses        220      218       -2     
Impacted Files Coverage Δ
src/parser.jl 84.41% <ø> (+0.56%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PhilReinhold
Copy link
Contributor Author

Hey, sorry for the delay. I've added a test for this case.

@kescobo
Copy link
Collaborator

kescobo commented Apr 18, 2023

Thanks for the contribution! I think this counts as a bug fix, rather than a new feature, yeah? (That is, it can go in a minor release)

@kescobo kescobo merged commit 8a65338 into JuliaData:master Apr 18, 2023
@kescobo kescobo mentioned this pull request Apr 18, 2023
@amilsted
Copy link

amilsted commented Jun 6, 2023

@kescobo Would you be open to doing a minor release to get this out?

@kescobo
Copy link
Collaborator

kescobo commented Jun 7, 2023

Thanks for the bump! JuliaRegistries/General#85034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants