CompatHelper: bump compat for "DataFrames" to "1.0" #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alyst - are your changes merged after 0.8 release breaking or non breaking? We should bump the RData.jl version appropriately. After this is fixed and RCall.jl gets a new release (to support DataFrames.jl 1.0 also) we should make a release here. In the next step we should make a release of RDatasets.jl (I thought of releasing it now but we have a dependency chain RCall.jl -> RData.jl -> RDatasets.jl that have to be released in this sequence) CC @nalimilan |
|
@bkamins The last changes should be non-breaking. Do you want to take care of updating RData.jl versions yourself? |
|
Yes - I will do it. Thank you! |
bkamins
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
DataFramespackage from0.21, 0.22to0.21, 0.22, 1.0.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.