Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DictoVec: cleanup and add tests #63

Merged
merged 2 commits into from
Jan 1, 2020
Merged

DictoVec: cleanup and add tests #63

merged 2 commits into from
Jan 1, 2020

Conversation

alyst
Copy link
Collaborator

@alyst alyst commented Aug 23, 2019

  • use explicit types for name2index, index2name
  • use Vector{RString?} for index2name
  • relax signatures (use AbstractVector, AbstractString, Integer)
  • fix show()
  • add DictoVec tests

@coveralls
Copy link

coveralls commented Aug 23, 2019 •
edited
Loading

Coverage Status

Coverage increased (+8.9%) to 85.797% when pulling 4c1a389 on alyst:ast/cleanup_dictovec into 94bc49e on JuliaData:master.

@alyst alyst force-pushed the ast/cleanup_dictovec branch from 60dd88d to fb28ecd Compare August 23, 2019 14:44
@alyst alyst force-pushed the ast/cleanup_dictovec branch 3 times, most recently from 0a03459 to 9b2aaa8 Compare September 21, 2019 22:33
@alyst alyst mentioned this pull request Dec 28, 2019
Merged
alyst added 2 commits January 1, 2020 15:16
@alyst
DictoVec: cleanup and add tests
22d7eff 
- use explicit types for name2index, index2name
- use Vector{RString?} for index2name
- relax signatures (use AbstractVector, AbstractString, Integer)
- fix show()
- add DictoVec tests
@alyst
DictoVec: add delete!(dv, key) method
4c1a389
@alyst alyst force-pushed the ast/cleanup_dictovec branch from 9b2aaa8 to 4c1a389 Compare January 1, 2020 14:20
@alyst alyst merged commit 0b7515d into JuliaData:master Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyst @coveralls