Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pure kwarg to map #71

Merged
merged 45 commits into from
Sep 1, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
6056598
add pure kwarg to map
bkamins Aug 13, 2021
62dcdb8
Update Project.toml
bkamins Aug 13, 2021
6745eef
Update runtests.jl
bkamins Aug 13, 2021
2de3717
Apply suggestions from code review
bkamins Aug 13, 2021
a3de2c3
Apply suggestions from code review
bkamins Aug 13, 2021
6be6bde
Update src/PooledArrays.jl
bkamins Aug 13, 2021
065629d
more efficient map for not-pure case
bkamins Aug 13, 2021
73ff1ed
Apply suggestions from code review
bkamins Aug 13, 2021
819bddf
Update src/PooledArrays.jl
bkamins Aug 13, 2021
4aef8d9
Update src/PooledArrays.jl
bkamins Aug 13, 2021
b3dc12c
Update test/runtests.jl
quinnj Aug 14, 2021
eb5f5ee
Update test/runtests.jl
quinnj Aug 14, 2021
9845443
Apply suggestions from code review
bkamins Aug 14, 2021
ef7b491
Update src/PooledArrays.jl
bkamins Aug 14, 2021
de11e9e
Update src/PooledArrays.jl
bkamins Aug 14, 2021
5d80486
Apply suggestions from code review
bkamins Aug 14, 2021
14bc92b
Update test/runtests.jl
bkamins Aug 14, 2021
75aacf9
Update test/runtests.jl
bkamins Aug 14, 2021
ef02b27
fix promotion
bkamins Aug 14, 2021
ebc4d0a
fix type chceck
bkamins Aug 14, 2021
f1b60b1
Apply suggestions from code review
bkamins Aug 14, 2021
d9a7e4a
Update src/PooledArrays.jl
bkamins Aug 14, 2021
60fdbfc
Update PooledArrays.jl
bkamins Aug 14, 2021
1716888
Apply suggestions from code review
bkamins Aug 14, 2021
8aab260
small changes
bkamins Aug 17, 2021
a6c6e65
Merge branch 'bkamins-patch-2' of https://github.com/JuliaData/Pooled…
bkamins Aug 17, 2021
a59e22a
remove type assertion
bkamins Aug 17, 2021
2f80224
Apply suggestions from code review
bkamins Aug 18, 2021
3a0b7e8
Update src/PooledArrays.jl
bkamins Aug 18, 2021
3a97346
Update src/PooledArrays.jl
bkamins Aug 18, 2021
72a6089
fix signature
bkamins Aug 18, 2021
09c2f20
Apply suggestions from code review
bkamins Aug 20, 2021
ade7029
Apply suggestions from code review
bkamins Aug 20, 2021
6acf2e8
Update src/PooledArrays.jl
bkamins Aug 20, 2021
a059bef
Update src/PooledArrays.jl
bkamins Aug 29, 2021
6a4bfa5
apply suggestions from code review
bkamins Aug 29, 2021
950d914
Apply suggestions from code review
bkamins Aug 29, 2021
5c13102
amend tests
bkamins Aug 29, 2021
4204992
fix Ti issues
bkamins Aug 31, 2021
aba380c
add Base.require_one_based_indexing test in inner constructor
bkamins Aug 31, 2021
60efc6f
fix offest checks for old Julia versions
bkamins Aug 31, 2021
b98ee8f
another fix to Julia 1.0
bkamins Aug 31, 2021
a146fa6
fix typo
bkamins Aug 31, 2021
97fe088
Apply suggestions from code review
bkamins Aug 31, 2021
0b21c63
apply review comments
bkamins Aug 31, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/map_inference.jl
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
for signed in (true, false), compress in (true, false), len in (1, 100, 1000)
x = PooledArray(fill(1, len), signed=true, compress=true);
bkamins marked this conversation as resolved.
Show resolved Hide resolved
@inferred PooledVector{Int, Int, Vector{Int}} map(identity, x)
end
5 changes: 1 addition & 4 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -560,8 +560,5 @@ end
@test y == fill(-1)
@test typeof(y) === PooledArray{Int, Int8, 0, Array{Int8, 0}}

for signed in (true, false), compress in (true, false), len in (1, 100, 1000)
x = PooledArray(fill(1, len), signed=true, compress=true);
VERSION >= v"1.6" && @inferred PooledVector{Int, Int, Vector{Int}} map(identity, x)
end
VERSION >= v"1.6" && include("map_inference.jl")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you avoid this by using @static?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - I will try

end