-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pool sharing with copy on write #56
Merged
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
96e5d3a
add pool sharing to PooledArrays
bkamins dd77169
further code review
bkamins 7932121
use Atomic{Int} and implement copyto!
bkamins 8dbee32
fix copy
bkamins 92850e5
fix typo
bkamins 995b3cd
fix leftover code
bkamins 4c407f3
add missing )
bkamins 00af820
fix small issues
bkamins 45a33a9
add missing method
bkamins da13879
another missing method
bkamins 665bf9a
fix various lurking problems (and bugs) in old code
bkamins cb1308c
Apply suggestions from code review
bkamins be31412
apply comments from the review
bkamins b41e9a1
improve getindex
bkamins 07e7b9c
add view
bkamins 1419283
Apply suggestions from code review
bkamins a1df0a0
Merge remote-tracking branch 'origin/main' into bk/pool_sharing
bkamins 0cb0021
add SubArray handling
bkamins be09d78
Apply suggestions from code review
bkamins 7f5f7e2
Update src/PooledArrays.jl
bkamins 61bcbdc
add PooledArrOrSub
bkamins 8ec3854
start adding tests
bkamins cd20319
Apply suggestions from code review
bkamins ee6100b
Merge remote-tracking branch 'origin/bk/pool_sharing' into bk/pool_sh…
bkamins 02b002b
merge methods (currently fails but I first need to understand if it i…
bkamins 21b3354
enough to remove where
bkamins ec0f710
simplify definition
bkamins 35430e0
update getindex
bkamins d3fb0a3
continue adding tests
bkamins b6e6c85
fix current tests
bkamins 2af32ca
finalize tests
bkamins c0333af
hopefully final fixes
bkamins 46d971c
add Julia 1.0.5 support
bkamins c55b8e9
Update src/PooledArrays.jl
bkamins 03a3221
fixes after code review
bkamins 0b8ba4d
Merge remote-tracking branch 'origin/bk/pool_sharing' into bk/pool_sh…
bkamins 3a92892
Update src/PooledArrays.jl
bkamins 49afb14
Merge remote-tracking branch 'origin/bk/pool_sharing' into bk/pool_sh…
bkamins 3eb65e7
Update src/PooledArrays.jl
bkamins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix current tests
- Loading branch information
commit b6e6c853f08403ba8afeb2fb396921481959a424
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nalimilan - this line fails without the special method for Julia 1.0: