Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment about storing mutable objects #52

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Jan 31, 2021

Fixes #51

@nalimilan - as usual - if you have comments on the language or in general how the docstring could be improved please let me know.

Fixes #51

@nalimilan - as usual - if you have comments on the language or in general how the docstring could be improved please let me know.
@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #52 (709bbca) into main (7cbaacb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   79.31%   79.31%           
=======================================
  Files           1        1           
  Lines         203      203           
=======================================
  Hits          161      161           
  Misses         42       42           
Impacted Files Coverage Δ
src/PooledArrays.jl 79.31% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cbaacb...fee731b. Read the comment docs.

@bkamins bkamins merged commit ff28ff2 into main Feb 1, 2021
@bkamins bkamins deleted the bkamins-patch-1 branch February 1, 2021 13:26
@bkamins
Copy link
Member Author

bkamins commented Feb 1, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow mutable eltype in PooledArray
2 participants