implement DataAPI #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2019 20:15
|
Had forgotten about this one, I've added the DataAPI dependency in the Project file, as it was released in the meantime. It should be good to go now. |
piever
commented
Dec 19, 2019
| [compat] | ||
| julia = "0.7, 1" | ||
| DataAPI = "1" | ||
| julia = "1" |
There was a problem hiding this comment.
Add to bump here as DataAPI requires julia 1.0 at least.
nalimilan
reviewed
Dec 20, 2019
nalimilan
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a draft as the package is not released yet (I'll make a Project.toml with the dependency when it is). See JuliaData/DataAPI.jl#4 for the roadmap.