Apply suggestions from code review

JuliaData · Nov 18, 2021 · f80d58e · f80d58e
1 parent 9c6dec9
commit f80d58e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/PooledArrays.jl b/src/PooledArrays.jl
@@ -590,12 +590,12 @@ end
 ##
 ##############################################################################
 
-function Base.push!(pv::PooledVector, v)
+function Base.push!(pv::PooledVector, v) # this function is not thread safe
     push!(pv.refs, getpoolidx(pv, v))
     return pv
 end
 
-function Base.insert!(pv::PooledVector, i::Integer, v)
+function Base.insert!(pv::PooledVector, i::Integer, v) # this function is not thread safe
     i isa Bool && throw(ArgumentError("invalid index: $i of type Bool"))
     if !(1 <= i <= length(pv.refs) + 1)
         throw(BoundsError("attempt to insert to a vector with length $(length(pv)) at index $i"))