Merge pull request #3 from JuliaComputing/s/searchsorted

use `searchsortedfirst` in `getpoolidx`
JuliaData · May 10, 2017 · ed9eef5 · ed9eef5
2 parents 47e6b14 + e42e4d7
commit ed9eef5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/PooledArrays.jl b/src/PooledArrays.jl
@@ -315,8 +315,8 @@ Base.getindex(A::PooledArray, I::AbstractArray) =
 
 function getpoolidx{T,R}(pa::PooledArray{T,R}, val::Any)
     val::T = convert(T,val)
-    pool_idx = findfirst(pa.pool, val)
-    if pool_idx <= 0
+    pool_idx = searchsortedfirst(pa.pool, val)
+    if pool_idx > length(pa.pool) || pa.pool[pool_idx] != val
         pool_idx = unsafe_pool_push!(pa, val)
     end
     return pool_idx