Skip to content

Commit

Permalink
Remove usage of Base internals (permute!!) (#87)
Browse files Browse the repository at this point in the history
  • Loading branch information
@LilithHafner
LilithHafner authored Sep 17, 2023
1 parent 1bb9c95 commit 25d6928
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "PooledArrays"
uuid = "2dfb63ee-cc39-5dd5-95bd-886bf059d720"
version = "1.4.2"
version = "1.4.3"

[deps]
DataAPI = "9a962f9c-6df0-11e9-0e5d-c546b8b5ee8a"
Expand Down
10 changes: 0 additions & 10 deletions src/PooledArrays.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -307,16 +307,6 @@ function Base.invpermute!(x::PooledArray, p::AbstractVector{T}) where T<:Integer
return x
end

function Base.permute!!(x::PooledArray, p::AbstractVector{T}) where T<:Integer
Base.permute!!(x.refs, p)
return x
end

function Base.invpermute!!(x::PooledArray, p::AbstractVector{T}) where T<:Integer
Base.invpermute!!(x.refs, p)
return x
end

Base.similar(pa::PooledArray{T,R}, S::Type, dims::Dims) where {T,R} =
PooledArray(RefArray(zeros(R, dims)), Dict{S,R}())

Expand Down

3 comments on commit 25d6928

@bkamins
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/91585

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.4.3 -m "<description of version>" 25d6928de934d5cb4f91668bd610a3ac6ae35c08
git push origin v1.4.3

@bkamins
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @LilithHafner @nalimilan

Please sign in to comment.