make sure we correctly pass matchmissing in joins (#3040)

Project.toml

@@ -1,6 +1,6 @@
 name = "DataFrames"
 uuid = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
-version = "1.3.2"
+version = "1.3.3"
 
 [deps]
 Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"

src/join/composer.jl

@@ -584,7 +584,8 @@ innerjoin(df1::AbstractDataFrame, df2::AbstractDataFrame, dfs::AbstractDataFrame
           makeunique::Bool=false,
           validate::Union{Pair{Bool, Bool}, Tuple{Bool, Bool}}=(false, false),
           matchmissing::Symbol=:error) =
-    innerjoin(innerjoin(df1, df2, on=on, makeunique=makeunique, validate=validate),
+    innerjoin(innerjoin(df1, df2, on=on, makeunique=makeunique, validate=validate,
+                        matchmissing=matchmissing),
               dfs..., on=on, makeunique=makeunique, validate=validate,
               matchmissing=matchmissing)
 
@@ -1042,7 +1043,8 @@ outerjoin(df1::AbstractDataFrame, df2::AbstractDataFrame, dfs::AbstractDataFrame
           on::Union{<:OnType, AbstractVector} = Symbol[], makeunique::Bool=false,
           validate::Union{Pair{Bool, Bool}, Tuple{Bool, Bool}}=(false, false),
           matchmissing::Symbol=:error) =
-    outerjoin(outerjoin(df1, df2, on=on, makeunique=makeunique, validate=validate),
+    outerjoin(outerjoin(df1, df2, on=on, makeunique=makeunique, validate=validate,
+                        matchmissing=matchmissing),
               dfs..., on=on, makeunique=makeunique, validate=validate,
               matchmissing=matchmissing)
 

test/join.jl

@@ -2184,4 +2184,19 @@ end
     @test df1.y isa Vector{Union{Int, Missing}}
 end
 
+@testset "passing matchmissing in multi-data frame innerjoin and outerjoin" begin
+    @test innerjoin(DataFrame(a=missing, b=1),
+                    DataFrame(a=missing, c=2),
+                    DataFrame(a=missing, d=3),
+                    on=:a, matchmissing=:equal) ≅ DataFrame(a=missing, b=1, c=2, d=3)
+    @test isempty(innerjoin(DataFrame(a=missing, b=1),
+                  DataFrame(a=missing, c=2),
+                  DataFrame(a=missing, d=3),
+                  on=:a, matchmissing=:notequal))
+    @test outerjoin(DataFrame(a=missing, b=1),
+                    DataFrame(a=missing, c=2),
+                    DataFrame(a=missing, d=3),
+                    on=:a, matchmissing=:equal) ≅ DataFrame(a=missing, b=1, c=2, d=3)
+end
+
 end # module