Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cut docstring #372

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Improve cut docstring #372

merged 1 commit into from
Oct 25, 2021

Conversation

nalimilan
Copy link
Member

The last interval is only closed on the right when extend=true is passed.

@bkamins I wonder whether we should always make the last interval closed (at least by default). This is what Hmisc::cut2 and classInt::classIntervals do in R.

@nalimilan
Improve cut docstring
be914e8 
The last interval is only closed on the right when `extend=true` is passed.
@bkamins
Copy link
Member

bkamins commented Oct 24, 2021

I wonder whether we should always make the last interval closed

I have always wondered why we do not do it by default. This would be breaking but, fortunately only slightly.

@nalimilan nalimilan mentioned this pull request Oct 25, 2021
Closed
@nalimilan
Copy link
Member Author

OK. We'll need a breaking release for other things anyway, so I've filed #373 so that we don't forget.

@nalimilan nalimilan merged commit ee3ccfe into master Oct 25, 2021
@nalimilan nalimilan deleted the nl/cut branch October 25, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkamins bkamins bkamins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalimilan @bkamins