Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doctests and make checks stricter #367

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Fix doctests and make checks stricter #367

merged 1 commit into from
Sep 15, 2021

Conversation

nalimilan
Copy link
Member

doctest=true is now the default.

@nalimilan
Fix doctests and make checks stricter
e0fd27c 
`doctest=true` is now the default.
@nalimilan nalimilan mentioned this pull request Sep 11, 2021
Merged
bkamins
bkamins approved these changes Sep 11, 2021
View reviewed changes
Copy link
Member

@bkamins bkamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve but Documenter.jl fails because of the levels issue that you address in the other PR.

@nalimilan
Copy link
Member Author

Documentation built successfully with latest DataAPI release.

@nalimilan nalimilan merged commit 7514576 into master Sep 15, 2021
@nalimilan nalimilan deleted the nl/docs branch September 15, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkamins bkamins bkamins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalimilan @bkamins