levels!(): enhance performance #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alyst - please allow if the review of the PR might be possibly delayed a bit. If you do not get any feedback in 10 days please bump and I will review (but @nalimilan is a better person to do this and I am sure he eventually will comment on it). Thank you! |
nalimilan
reviewed
Jul 11, 2021
nalimilan
reviewed
Jul 24, 2021
|
gentle bump |
nalimilan
reviewed
Aug 17, 2021
test/12_missingarray.jl
Outdated
Comment on lines
219
to
225
| # check that x is restored correctly when dropping levels is not allowed | ||
| @test_throws ArgumentError levels!(x, ["e", "c"]) | ||
| @test x == ["c", "b", "b"] | ||
| @test levels(x) == ["e", "a", "b", "c"] | ||
|
|
||
| @test levels!(x, ["e", "c"], allowmissing=true) === x | ||
| @test levels(x) == ["e", "c"] | ||
| @test x[1] === CategoricalValue(x.pool, 2) | ||
| @test x[2] === missing | ||
| @test x[3] === missing | ||
| @test levels(x) == ["e", "c"] |
There was a problem hiding this comment.
Also apply these changes to 11_array.jl.
There was a problem hiding this comment.
done. I've addressed your latest review (thanks!) and squashed the commits.
nalimilan
reviewed
Aug 19, 2021
test/11_array.jl
Outdated
Comment on lines
190
to
200
| @test_throws ArgumentError levels!(x, ["a"]) | ||
| # check that x is restored correctly when dropping levels is not allowed | ||
| @test x == ["a", "b", "b"] | ||
| @test levels(x) == ["b", "a"] | ||
|
|
||
| @test_throws ArgumentError levels!(x, ["e", "b"]) | ||
|
|
||
| @test_throws ArgumentError levels!(x, ["e", "a", "b", "a"]) | ||
| # one again check that x is restored correctly when dropping levels is not allowed | ||
| @test x == ["a", "b", "b"] | ||
| @test levels(x) == ["b", "a"] |
There was a problem hiding this comment.
Sorry to be a pain, but there are equivalent lines in 12_missingarray.jl: can you keep them in sync? :-)
test levels!() exceptions handling and rollback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the performance of
levels!()by avoiding redundant checks for duplicate new levels, levels intersection, recoding etc.These checks become expensive as the number of levels grow.