Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes plotting with Plots.jl, preserving the custom ordering of levels.
Fixes #256.
@daschw @mkborregaard Does this sound correct? I had to adjust the recipe you wrote at JuliaPlots/Plots.jl#2519 (comment) to support missing values. Since the recipe only has access to
CategoricalValue
entries and not the the parentCategoricalArray
, I couldn't find a way to detect whether the array has aUnion{<: CategoricalValue, Missing}
eltype, so I always includemissing
in the set of possible values. But AFAICTplot
automatically skips them when they are not present so I guess it's OK?Also I've tried to write basic tests without relying on heavy checks of the produced graphs, let me know if there's a better way.