Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wplotim is destructive #71

Closed
Dejan-Ilic opened this issue May 31, 2021 · 2 comments · Fixed by #72
Closed

wplotim is destructive #71

Dejan-Ilic opened this issue May 31, 2021 · 2 comments · Fixed by #72

Comments

@Dejan-Ilic
Copy link

wplotim modifies the argument x it receives. I think either the function should be renamed to wplotim!
or on line 83 of Plot.jl xts = x should be changed to xts = copy(x) (which seems the best option to me). Thanks for your time :)
@JeffFessler JeffFessler mentioned this issue May 31, 2021
Merged
@JeffFessler
Copy link
Contributor

nice catch, thanks.
a workaround while waiting for a new version is wplotim(copy(x))

gummif added a commit that referenced this issue May 31, 2021
@gummif
Merge pull request #72 from JeffFessler/master
5ca64c7 
fix #71 wplotim modified input
@gummif
Copy link
Member

gummif commented May 31, 2021

Good catch, a fix has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #71 wplotim modified input
3 participants
@gummif @JeffFessler @Dejan-Ilic