Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conv for empty arrays #628

Merged
merged 4 commits into from
Mar 21, 2025
Merged

Fix conv for empty arrays #628

merged 4 commits into from
Mar 21, 2025

Conversation

wheeheee
Copy link
Member

@wheeheee wheeheee commented Mar 5, 2025

Fixes #168 and adds tests

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (d08699a) to head (12ca69f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #628   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files          19       19           
  Lines        3277     3277           
=======================================
  Hits         3216     3216           
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just could maybe use a test for conv of two empty arrays. @test conv(B, B; algorithm) == B might do the trick?
Should we include a version bump here and release?

@wheeheee
Copy link
Member Author

Yeah, sounds good.

@martinholters martinholters merged commit 66acd7d into master Mar 21, 2025
11 checks passed
@martinholters martinholters deleted the conv-0 branch March 21, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conv corner case
2 participants