-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't evict whole cache for large entries #40
Conversation
lru.currentsize += s | ||
lru.dict[key] = (v, n, s) | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this so the return type is nothing
independently of which branch we take. Note the return of _unsafe_index!
isn't used anywhere in the codebase
@@ -1,6 +1,6 @@ | |||
name = "LRUCache" | |||
uuid = "8ac3fa9e-de4c-5943-b1dc-09c6b5f20637" | |||
version = "1.4.1" | |||
version = "1.5.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
counted this as a "feature", but I think it could also be seen as a bugfix (and thus a patch release)
Could you review @Jutho? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this very nice PR (and for the review reminder). Looks good to me. I will check whether the GitHub actions need any updating before tagging a the new version.
1.5.0 is tagged, but it seems there is something wrong with tagbot configuration as new tags are not being registered on github. Even 1.4 was also missed as it only goes up to 1.3. Something to look into. |
maybe the configuration or a key needs to be updated? |
Closes #37