Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max size is a required argument making a read me example wrong #32

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

this-josh
Copy link
Contributor

This is a trivial change but should make it slightly easier for new users. max_size is a required argument so its absence makes the bottom example fail. In the creation section it is suggested that max_size has a default value but for me this doesn't seem to be the case, perhaps this needs updating/rectifying too.

Its absence makes this example fail
@Jutho
Copy link
Collaborator

Jutho commented Nov 4, 2022

Thanks for this very essential correction.

@Jutho Jutho merged commit 7c4e6d1 into JuliaCollections:master Nov 4, 2022
@this-josh
Copy link
Contributor Author

You are most welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants