Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide hooks for custom backends #401

Merged
merged 14 commits into from
Jul 19, 2021
Merged

provide hooks for custom backends #401

merged 14 commits into from
Jul 19, 2021

Conversation

ericphanson
Copy link
Member

Instead of adding a whole new backend as in #396, I thought it would be better to just start with an AbstractBackend to provide hooks to use alternate backends. This way we don't need to bump the Julia requirements to start trying out alternate backends downstream. It also provides a smaller incremental step than having AbstractBackends + a specific alternate backend in the same PR.

This also provides what is hopefully a useful feature: you could do

using AWS
AWS.DEFAULT_BACKEND[] = HTTPBackend(custom_http_options)

to specify custom HTTP options globally in your application (which can still be overwritten per-request); I would have found this useful when trying experiments like tweaking the pipelining and connection pooling settings.

In the same way, a Downloads.jl-based backend could pass a Downloads.Downloader along inside the backend object instead of requiring adding more fields to Request for the downloader like in #396.

@ericphanson
Copy link
Member Author

This still needs tests for the new functionality but I'll kick off bors to see if I correctly updated the tests.

bors try

bors bot added a commit that referenced this pull request Jul 13, 2021
@bors
Try #401:
5927acc
@bors
Copy link
Contributor

bors bot commented Jul 13, 2021

try

Build failed:

@ericphanson
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 13, 2021
@bors
Try #401:
34b63c0
ericphanson
ericphanson commented Jul 13, 2021
View reviewed changes
@bors
Copy link
Contributor

bors bot commented Jul 13, 2021

try

Build succeeded:

omus
omus reviewed Jul 14, 2021
View reviewed changes
@ericphanson
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 16, 2021
@bors
Try #401:
58a6db7
@bors
Copy link
Contributor

bors bot commented Jul 16, 2021

try

Build failed:

@ericphanson
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 16, 2021
@bors
Try #401:
0dec135
@bors
Copy link
Contributor

bors bot commented Jul 16, 2021

try

Build succeeded:

omus
omus reviewed Jul 17, 2021
View reviewed changes
@ericphanson
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 19, 2021
@bors
Try #401:
c0bf699
@bors
Copy link
Contributor

bors bot commented Jul 19, 2021

try

Build succeeded:

@ericphanson
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 19, 2021
@bors
Try #401:
3834754
@bors
Copy link
Contributor

bors bot commented Jul 19, 2021

try

Build succeeded:

@ericphanson ericphanson requested a review from omus July 19, 2021 16:48
@omus
Copy link
Member

omus commented Jul 19, 2021

bors r+

@ericphanson
Copy link
Member Author

Awesome, thanks! Can we get a release with it when it goes through? Excited to use this downstream

@bors
Copy link
Contributor

bors bot commented Jul 19, 2021

Build succeeded:

@bors bors bot merged commit afb9a38 into JuliaCloud:master Jul 19, 2021
@ericphanson ericphanson deleted the eph/abstractbackend branch July 19, 2021 17:21
@ericphanson ericphanson mentioned this pull request Jul 19, 2021
Merged
bors bot added a commit that referenced this pull request Jul 19, 2021
@bors @ericphanson
Merge #405
76619b8 
405: Bump version for feature release r=mattBrzezinski a=ericphanson

to get in #401 

Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
@ericphanson ericphanson mentioned this pull request Jul 19, 2021
Merged
@ericphanson ericphanson mentioned this pull request Aug 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omus omus omus approved these changes

@mattBrzezinski mattBrzezinski Awaiting requested review from mattBrzezinski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericphanson @omus