Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark time = 0 #34

Closed
d-netto opened this issue Jun 29, 2022 · 5 comments
Closed

mark time = 0 #34

d-netto opened this issue Jun 29, 2022 · 5 comments

Comments

@d-netto
Copy link
Collaborator

d-netto commented Jun 29, 2022

Happened when running tree_mutable.jl on JuliaLang/julia#45639.

threads = 2
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │      17269 │    7583 │         0 │         31 │          227 │                55 │      612 │         44 │
│  median │      17269 │    7583 │         0 │         31 │          227 │                55 │      612 │         44 │
│ maximum │      17269 │    7583 │         0 │         31 │          227 │                55 │      612 │         44 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘
@d-netto
Copy link
Collaborator Author

d-netto commented Jun 29, 2022

Seems to be reproducible on master as well:

bench = "tree_mutable.jl"
┌─────────┬────────────┬─────────┬───────────┬────────────┬──────────────┬───────────────────┬──────────┬────────────┐
│         │ total time │ gc time │ mark time │ sweep time │ max GC pause │ time to safepoint │ max heap │ percent gc │
│         │         ms │      ms │        ms │         ms │           ms │                us │       MB │          % │
├─────────┼────────────┼─────────┼───────────┼────────────┼──────────────┼───────────────────┼──────────┼────────────┤
│ minimum │      19326 │    8624 │         0 │         33 │          273 │                56 │      603 │         44 │
│  median │      19984 │    9278 │         0 │         39 │          273 │                57 │      603 │         46 │
│ maximum │      22215 │   10962 │         0 │         47 │          276 │                74 │      610 │         49 │
└─────────┴────────────┴─────────┴───────────┴────────────┴──────────────┴───────────────────┴──────────┴────────────┘

@oscardssmith
Copy link
Collaborator

@chflood are the times in the wrong places?

@d-netto
Copy link
Collaborator Author

d-netto commented Jun 29, 2022

Also, mark + sweep times seem to be discrepant from gc time. I wouldn't expect them to add up, but would expect them to be in the same order of magnitude.

@chflood
Copy link
Collaborator

chflood commented Jun 30, 2022 via email

@d-netto
Copy link
Collaborator Author

d-netto commented Jul 21, 2022

Resolved a few commits ago.

@d-netto d-netto closed this as completed Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants