Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct 0.5 dev version in README #8

Merged
merged 1 commit into from
Apr 29, 2016
Merged

Conversation

stevengj
Copy link
Contributor

@stevengj stevengj commented Dec 9, 2015

You should check for the version where JuliaLang/julia#13062 was merged.

You should check for the version where JuliaLang/julia#13062 was merged.
@IainNZ
Copy link
Contributor

IainNZ commented Dec 10, 2015

Why?

@stevengj
Copy link
Contributor Author

Because the code is not correct for all 0.5-dev versions? Of course, as a practical matter, not many people are likely to use a version where the difference matters. It's more the general principle that VERSION >= v"X.Y-" checks should be viewed as automatically suspect.

@tkelman
Copy link
Contributor

tkelman commented Apr 28, 2016

Bump. I'm going to merge this. Helps if this code ever needs to be used in bisecting something. @stevengj want an invite to the JuliaCI org?

@stevengj
Copy link
Contributor Author

Sure.

@tkelman tkelman merged commit 094389f into JuliaCI:master Apr 29, 2016
@stevengj stevengj deleted the patch-1 branch April 29, 2016 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants