-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Project.toml #19
add Project.toml #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you also delete the REQUIRE
file, in the project directory and in test
?
Project.toml
Outdated
Compat = "34da2185-b29b-5c13-b0c7-acf172513d20" | ||
|
||
[compat] | ||
Compat = "≥ 0.53.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these need to have upper bounds in order to be efficiently merged to the registry: https://discourse.julialang.org/t/announcement-automatic-merging-for-the-general-registry/29961.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've removed the inequalities, and added a CompatHelper commit to help keep the compat section up-to-date going forward. not sure if that commit is all that's needed to install it though.
@@ -0,0 +1,19 @@ | |||
name = "IndirectArrays" | |||
uuid = "9b13fd28-a010-5f03-acff-a1bbcff69959" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need a version
number here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what version number though? i left it out because i thought additional PRs might be merged before a new release is tagged, and depending on their content it's hard to know whether the major, minor, or point number would be bumped.
f9e1fc5
to
789e280
Compare
lastly, i've added TagBot |
oh, and the REQUIREs are deleted. anything else? |
a00b9cf
to
8eefc57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, but CI has to pass before we can merge this. Check the logs (click on the Details
link) to see the reason for failure.
Project.toml
Outdated
|
||
[compat] | ||
Compat = "0.53" | ||
FixedPointNumbers = "0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FixedPointNumbers = "0.3" | |
FixedPointNumbers = "0.6.1, 0.7" |
0.3 doesn't work on Julia 1.x, and your version blocks it from using any newer version.
Project.toml
Outdated
Compat = "34da2185-b29b-5c13-b0c7-acf172513d20" | ||
|
||
[compat] | ||
Compat = "0.53" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check CI, you'll see it's failing because of this line. Does this package actually use Compat
anymore?
.github/workflows/CompatHelper.yml
Outdated
|
||
on: | ||
schedule: | ||
- cron: '* * * * 0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://crontab.guru/#*_*_*_*_0 suggests this means "every minute on Sunday"!
8eefc57
to
c03517b
Compare
c03517b
to
19b6280
Compare
Thanks for doing this! |
needed for julia 1.4 it seems.