Add append! for AbstractVector second argument (#15)

JuliaArrays · Apr 4, 2018 · 926e76a · 926e76a
1 parent 8dc1dff
commit 926e76a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/IndirectArrays.jl b/src/IndirectArrays.jl
@@ -102,4 +102,11 @@ function Base.append!(A::IndirectArray{T,1}, B::IndirectArray{T,1}) where T
     return A
 end
 
+function Base.append!(A::IndirectArray{<:Any,1}, B::AbstractVector)
+    for b in B
+        push!(A, b)
+    end
+    return A
+end
+
 end # module
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -26,6 +26,9 @@ xc[2], xc[3] = RGB(0,1,0), RGB(0,1,1)
 @test append!(x, x) == IndirectArray([colors[:]; colors[:]])
 @test append!(x, IndirectArray([RGB(1,0,0), RGB(1,1,0)])) ==
     IndirectArray([colors[:]; colors[:]; [RGB(1,0,0), RGB(1,1,0)]])
+# Append with non-IndirectArray
+@test append!(IndirectArray(colors[:]), IndirectArray(colors[:])) ==
+      append!(IndirectArray(colors[:]), colors[:])
 
 # Bounds checking upon construction
 index_ob = copy(index0)