Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now in Base #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

PallHaraldsson
Copy link

[skip ci]

[skip ci]
@PallHaraldsson
Copy link
Author

Maybe deprecate this package (as we do want users to adopt this style?), or not, as Julia LTS still important. If I recall, it's in Julia 1.4, and e.g. begin, not ibegin.

@timholy
Copy link
Member

timholy commented Apr 23, 2020

You'll need a more nuanced statement, try the view example in the README without using ibegin.

Co-authored-by: Curtis Vogt <curtis.vogt@gmail.com>
@timholy
Copy link
Member

timholy commented May 26, 2020

It's not just that the syntax is different. This can do stuff that Base can't, and vice versa. Like I said, try to get the view example in the README to work without using this package.

I'm all in favor of updating the README with information about the improvements in Julia itself, it's just that the statement has to be accurate.

@PallHaraldsson
Copy link
Author

PallHaraldsson commented May 27, 2020

I think you could pull the latest commit (and not complicate my text further; people could see here on mix-and match).

Not too important thoughts:
I just thought/assumed your package completely redundant. I'm not actually using the package.

I thought it regrettable if people use this package, with non-standard "syntax" (strictly speaking completely Julia syntax). I guess you can and must mix and match new syntax, and e.g. your view on different (or same lines).

You could even mix like, while I guess not advised:

a[1:(begin+iend)÷2] == a[1:10]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants