-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AxisMatrix alias #199
Add AxisMatrix alias #199
Conversation
for consistency with `AbstractArray` and `AbstractMatrix` and other such types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and maybe also AbstractVector
?
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
=========================================
Coverage ? 89.31%
=========================================
Files ? 7
Lines ? 674
Branches ? 0
=========================================
Hits ? 602
Misses ? 72
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have other high-priority tasks that need my care so I only merged the urgent one #201 made a patch release for it. Hope you understand.
Approval for the goal here but won't ship it very soon.
Thanks @johnnychen94 for handling the important one. This one is not urgent at all... |
Should |
Yes, and |
done #222 . Note that unlike |
for consistency with
AbstractArray
andAbstractMatrix
and other such types