Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AxisMatrix alias #199

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Add AxisMatrix alias #199

merged 3 commits into from
Apr 1, 2022

Conversation

JeffFessler
Copy link
Contributor

for consistency with AbstractArray and AbstractMatrix and other such types

for consistency with `AbstractArray` and `AbstractMatrix` and other such types
Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and maybe also AbstractVector?

src/core.jl Outdated Show resolved Hide resolved
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@9b91d54). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #199   +/-   ##
=========================================
  Coverage          ?   89.31%           
=========================================
  Files             ?        7           
  Lines             ?      674           
  Branches          ?        0           
=========================================
  Hits              ?      602           
  Misses            ?       72           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b91d54...3a76035. Read the comment docs.

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have other high-priority tasks that need my care so I only merged the urgent one #201 made a patch release for it. Hope you understand.

Approval for the goal here but won't ship it very soon.

@JeffFessler
Copy link
Contributor Author

Thanks @johnnychen94 for handling the important one. This one is not urgent at all...

@johnnychen94 johnnychen94 merged commit 83e3280 into JuliaArrays:master Apr 1, 2022
@JeffFessler JeffFessler deleted the axismatrix branch April 1, 2022 02:11
@cmichelenstrofer
Copy link
Contributor

Should AxisMatrix be exported?

@JeffFessler
Copy link
Contributor Author

Yes, and AxisVector too I think. That was an oversight on my part when I made the original PR.
Want to make a PR?

@cmichelenstrofer
Copy link
Contributor

cmichelenstrofer commented Jul 4, 2023

done #222 . Note that unlike Vector or Matrix, AxisMatrix and AxisVector don't work as constructors (a bunch of new constructors would have to be created mirroring those for AxisArray). They are still useful for limiting function argument types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants