-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotting for weighted bases #96
Conversation
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 89.58% 90.77% +1.18%
==========================================
Files 7 7
Lines 509 531 +22
==========================================
+ Hits 456 482 +26
+ Misses 53 49 -4
Continue to review full report at Codecov.
|
Can you add tests? See ContinuumArrays.jl/test/runtests.jl Line 600 in f3e0d96
We probably want to add tests to the quick-and-dirty weighted Chebyshev defined above ContinuumArrays.jl/test/runtests.jl Line 515 in f3e0d96
|
Yes, will do. |
This works for finite case and PaddedLayout infinite case. I'm not sure if there is an easy way to make this work for more generic infinite case of e.g. broadcast vectors as well but that doesn't seem supported for the unweighted bases either so that's probably fine for now. |
Can you bump the patch version so I can merge and tag? |
I guess 0.7.5 is ok? done. |
See JuliaApproximation/MultivariateOrthogonalPolynomials.jl#73 (comment) and JuliaApproximation/MultivariateOrthogonalPolynomials.jl#73 (comment)
So I think this does actually just work as you said @dlfivefifty. At least testing it for weighted Zernike and weighted Jacobi gives the expected correct plots.